Skip to content

0.0.8 release#298

Merged
shammamah-zz merged 5 commits into
masterfrom
0.0.8-release
Apr 2, 2019
Merged

0.0.8 release#298
shammamah-zz merged 5 commits into
masterfrom
0.0.8-release

Conversation

@shammamah-zz

Copy link
Copy Markdown
Contributor

About

Releasing a new official version of Dash Bio package.

Description of changes

See CHANGELOG.

Before merging

@shammamah-zz
shammamah-zz temporarily deployed to dash-bio-test-pr-298 April 1, 2019 20:57 Inactive
@shammamah-zz
shammamah-zz temporarily deployed to dash-bio-test-pr-298 April 1, 2019 21:04 Inactive
@shammamah-zz
shammamah-zz temporarily deployed to dash-bio-test-pr-298 April 1, 2019 21:05 Inactive
@shammamah-zz
shammamah-zz requested a review from mkcor April 1, 2019 21:09
@mkcor

mkcor commented Apr 2, 2019

Copy link
Copy Markdown
Contributor

More, precisely, it is a new major version zero (https://semver.org/).

@mkcor mkcor left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this doesn't make sense, because then version 0.0.8-rc13 and version 0.0.8 are identical... whereas you would expect 0.0.8-rc13 < 0.0.8 (https://semver.org/).

@mkcor

mkcor commented Apr 2, 2019

Copy link
Copy Markdown
Contributor

Since I have merged #299 (dependency update), syncing up this branch with master will bring a change wrt v0.0.8-rc13. So, then, I'm fine considering that we can increment the version number and, hence, release v0.0.8!

@mkcor

mkcor commented Apr 2, 2019

Copy link
Copy Markdown
Contributor

I think this doesn't make sense, because then version 0.0.8-rc13 and version 0.0.8 are identical... whereas you would expect 0.0.8-rc13 < 0.0.8 (https://semver.org/).

Or maybe it does make sense, since any of the 0.0.8-rc* versions (release candidates) could have become version 0.0.8 after passing QA and assuming no change was needed... (not sure ;))

@shammamah-zz

shammamah-zz commented Apr 2, 2019

Copy link
Copy Markdown
Contributor Author

@mkcor Yeah, that was my logic! I figure that a (successful) release candidate shouldn't need to be modified for the release.

@shammamah-zz
shammamah-zz merged commit d477d56 into master Apr 2, 2019
@shammamah-zz
shammamah-zz deleted the 0.0.8-release branch April 2, 2019 13:12
@mkcor mkcor mentioned this pull request Apr 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants